ConstraintElim: assert on invalid union field (NFC) #115898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getContextInst currently returns an invalid union field, when it is called with a ConditionFact, although existing callers don't do this. In order to error out early and serve as documentation for future callers, add an assert forbidding the behavior.
Member
|
@llvm/pr-subscribers-llvm-transforms Author: Ramkumar Ramachandra (artagnon) ChangesgetContextInst currently returns an invalid union field, when it is called with a ConditionFact, although existing callers don't do this. In order to error out early and serve as documentation for future callers, add an assert forbidding the behavior. Full diff: https://github.com/llvm/llvm-project/pull/115898.diff 1 Files Affected:
diff --git a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
index 7c06e0c757e1cc..d2e532d29d07b5 100644
--- a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
@@ -164,6 +164,7 @@ struct FactOrCheck {
}
Instruction *getContextInst() const {
+ assert(!isConditionFact());
if (Ty == EntryTy::UseCheck)
return getContextInstForUse(*U);
return Inst;
|
Contributor
|
Thanks for adding the assert! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getContextInst currently returns an invalid union field, when it is called with a ConditionFact, although existing callers don't do this. In order to error out early and serve as documentation for future callers, add an assert forbidding the behavior.